Repository navigation
CLI: keep transaction CBOR in Yaci Store - #205
Merged
Merged
Conversation
Enables store.transaction.save-cbor so /txs/{hash}/cbor works on devnets. The viewer needs
the raw transaction to replay and debug script executions exactly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Initial automated review · Aster Hi @satran004, thanks for the PR! 🙏 This is an automatic first check by an AI reviewer. It does not replace maintainer review and may be wrong. Reviewed commit: Issues found:
Not tested: Build and devnet CBOR retrieval were not run; native-build CI is still in progress. |
55 of 72 tasks
Without it the parser returns no body CBOR, nothing is saved and
/txs/{hash}/cbor stays 404.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Added b6d2a35, which also sets
🤖 Generated with Claude Code |
setup-graalvm with distribution 'liberica' and java-version '21' picks the newest Liberica NIK release. Its 21.0.13 release is tagged jdk-21.0.13+6 but its assets are named 21.0.13.0.3+6, so the action finds no asset and every build fails at setup. Pin the GraalVM that release-cli.yml already uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`version: '21.0.5'` no longer resolves: setup-graalvm looks only among the 10 newest GDS builds for JDK 21, and 21.0.5 has dropped out of them (the oldest listed is now 21.0.8). With `java-version: '21.0.5'` and no `version`, the action downloads the same build from download.oracle.com/graalvm/21/archive/. Applies to build.yml, release-cli.yml and dev-release-cli.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The store is cloned and built with its own wrapper, which uses the 10 s default networkTimeout. On GitHub runners the gradle-8.10 download from services.gradle.org stalls longer than that, failing the native build three times in a row (timeouts and a 504). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
store.transaction.save-cbor=truein the Yaci Store config that the CLI generates. With it,/api/v1/txs/{hash}/cborworks on devnets.Why: Yaci Viewer's planned Script Lab (#207) re-runs and debugs script executions in the browser with the julc WebAssembly engine. Replay already works from structured store data. Raw transaction CBOR is what will make it byte-exact (once julc can evaluate from CBOR, bloxbean/julc#244). It also enables "why won't my tx submit?" debugging.
Scope: applies to newly created devnets, because the store config is written when a devnet is created. Storage cost on a devnet is negligible.
Testing:
./gradlew compileJava. Before this change, the devnet store returned 404 "Make sure store.transaction.save-cbor=true is enabled" for/txs/{hash}/cbor.🤖 Generated with Claude Code